Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #1540

Merged
merged 5 commits into from
May 26, 2022
Merged

Refactoring #1540

merged 5 commits into from
May 26, 2022

Commits on May 26, 2022

  1. refactor: don't create BigNumber instances without new

    @davidyuk
    davidyuk committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4ac9652 View commit details
    Browse the repository at this point in the history

  2. refactor: don't use parseInt

    @davidyuk
    davidyuk committed May 26, 2022
    Configuration menu
    Copy the full SHA
    2346dcf View commit details
    Browse the repository at this point in the history

  3. refactor!: drop ensureNameValid 

    the TypeScript check would be used later instead

BREAKING CHANGE: removed `ensureNameValid`
Use a TypeScript check instead.
    @davidyuk
    davidyuk committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d0d1258 View commit details
    Browse the repository at this point in the history

  4. refactor(tx schema): drop unnecessary TX_FIELD wrapper

    @davidyuk
    davidyuk committed May 26, 2022
    Configuration menu
    Copy the full SHA
    3752241 View commit details
    Browse the repository at this point in the history

  5. test: await promise instead of returning it

    @davidyuk
    davidyuk committed May 26, 2022
    Configuration menu
    Copy the full SHA
    4e762fe View commit details
    Browse the repository at this point in the history