Refactor RPC and rewrite aepp-rpc to TypeScript #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: AeppRpc doesn't accept `connection` anymore Use `connectToWallet` method instead.
BREAKING CHANGE: `handlers` parameter is removed in RpcClient Provide a `methods` parameter instead of `handlers[0]`. Provide an `onDisconnect` parameter instead of `handlers[1]`.
BREAKING CHANGE: `sendMessage` of RpcClient is a private method
Use `request` or `notify` instead.
BREAKING CHANGE: `shareWalletInfo` of WalletRpc accepts rpcClientId instead of callback
For example, rewrite
```
const connection = new BrowserRuntimeConnection({ port })
aeSdk.addRpcClient(connection)
aeSdk.shareWalletInfo(port.postMessage.bind(port))
```
to
```
const connection = new BrowserRuntimeConnection({ port })
const rpcClientId = aeSdk.addRpcClient(connection)
aeSdk.shareWalletInfo(rpcClientId)
```
BREAKING CHANGE: `connectToWallet` accepts wallet connection as the first argument See connect-aepp-to-wallet.md for details. BREAKING CHANGE: `disconnectWallet` runs in sync and `sendDisconnect` arg removed So, aepp would always send `closeConnection` notification. BREAKING CHANGE: `sendConnectRequest` removed Use `connectToWallet` instead.
Message counted is maintained locally, so this shouldn't be a case
|
This pull request introduces 1 alert and fixes 1 when merging 1a8e830 into a169e5e - view on LGTM.com new alerts:
fixed alerts:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.