refactor(wallet-rpc)!: rewrite to TypeScript #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
feature/wallet-ts
branch
from
68d10b1
to
77e6920
Compare
BREAKING CHANGE: RpcClient doesn't contain aepp info anymore Get aepp info in `onConnection` callback, and store somehow to use later.
BREAKING CHANGE: RpcClient has no `origin` property Use `connection` property instead.
BREAKING CHANGE: wallet can't selectively notify aepps about selecting/adding account If you need this feature, create a custom wallet implementation. BREAKING CHANGE: wallet can't provide metadata for accounts If you need this feature, create a custom wallet implementation.
BREAKING CHANGE: wallet-rpc can't handle specific account set for app anymore If you need this feature, create a custom wallet implementation.
BREAKING CHANGE: `onDisconnect` callback on wallet side accepts client id instead of RpcClient Use `sdk.rpcClient[clientId]` to get the corresponding instance of RpcClient.
BREAKING CHANGE: `rpcClients` in wallet is not exposed anymore
davidyuk
force-pushed
the
feature/wallet-ts
branch
from
77e6920
to
fba4075
Compare
BREAKING CHANGE: wallet callbacks accepts aeppId, params, and origin
BREAKING CHANGE: `txObject` parameter of `onSign` callback is removed Use `unpackTx(tx)` on wallet side instead.
davidyuk
force-pushed
the
feature/wallet-ts
branch
from
fba4075
to
930e7d7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.