Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes around sendTransaction #1953

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Fixes around sendTransaction #1953

merged 7 commits into from
Mar 4, 2024

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Mar 2, 2024

This PR is supported by the Æternity Foundation

@davidyuk davidyuk added this to the v13.3.0 milestone Mar 2, 2024
@davidyuk davidyuk marked this pull request as ready for review March 4, 2024 09:52
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 89.55224% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 79.95%. Comparing base (a21bc1f) to head (d9cde12).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/send-transaction.ts 88.88% 1 Missing and 3 partials ⚠️
src/tx/builder/field-types/fee.ts 50.00% 0 Missing and 1 partial ⚠️
src/tx/builder/field-types/ttl.ts 50.00% 1 Missing ⚠️
src/tx/builder/index.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1953      +/-   ##
===========================================
+ Coverage    79.91%   79.95%   +0.04%     
===========================================
  Files          101      102       +1     
  Lines         3450     3463      +13     
  Branches       733      735       +2     
===========================================
+ Hits          2757     2769      +12     
  Misses         381      381              
- Partials       312      313       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk merged commit 48ee661 into develop Mar 4, 2024
5 checks passed
@davidyuk davidyuk deleted the feature/fixes branch March 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant