Channel tx serializations #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mpowaga
commented
Mar 7, 2019
•
mpowaga
commented
- CHANNEL_OFFCHAIN_TX
- CHANNEL_OFFCHAIN_CREATE_CONTRACT_TX
- CHANNEL_OFFCHAIN_CALL_CONTRACT_TX
- CHANNEL_OFFCHAIN_UPDATE_TRANSFER_TX
- CHANNEL_OFFCHAIN_UPDATE_DEPOSIT_TX
- CHANNEL_OFFCHAIN_UPDATE_WITHDRAWAL_TX
- CHANNEL_CLOSE_SOLO_TX
- CHANNEL_SLASH_TX
- PROOF_OF_INCLUSION_TX
- ACCOUNT
- CONTRACT
- CONTRACT_CALL
- CHANNEL
- CHANNEL_SNAPSHOT_TX
- CHANNEL_FORCE_PROGRESS_TX
- CHANNELS_TREE
- NAMESERVICE_TREE
- ORACLES_TREE
- ACCOUNTS_TREE
mpowaga
requested review from
nduchak and
ricricucit
and removed request for
ricricucit and
nduchak
* Make sure that sign function is correctly called * Improve error handling for update method
* refactor(Chain and Contract): Fix Chain.getAccount. Omprove Compiler Add ability to get account/balance on specific block hash/height. Add test. Add changeCompilerUrl to Compiler stamp #302 * fix(Crypto): Fix name hash function arguments parsing * refactor(Compiler): Remove async for changeCompilerUrl function
* Add support for contracts in state channels * Remove console.log * Remove console.log * Improve channel rpc usage (#275) * Improve channel rpc usage * Fix lint error * Remove unreachable code * Improve channel tests and error handling (#276) * Make sure that sign function is correctly called * Improve error handling for update method * Improve state channel params handling. Fixes #299 (#300)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.