Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Oracle): remove unnecessary binding #885

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Jan 30, 2020

No description provided.

@nduchak nduchak self-assigned this Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #885 into develop will increase coverage by 26.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #885       +/-   ##
============================================
+ Coverage    66.39%   92.55%   +26.15%     
============================================
  Files           43       57       +14     
  Lines         2303     2846      +543     
============================================
+ Hits          1529     2634     +1105     
+ Misses         774      212      -562
Impacted Files Coverage Δ
es/channel/handlers.js 79.27% <0%> (-0.91%) ⬇️
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 98.86% <0%> (ø)
es/ae/aepp.js 100% <0%> (ø)
es/rpc/server.js 100% <0%> (ø)
es/index.js 100% <0%> (ø)
es/utils/aepp-wallet-communication/rpc/aepp-rpc.js 100% <0%> (ø)
es/ae/wallet.js 100% <0%> (ø)
es/utils/aepp-wallet-communication/schema.js 94.44% <0%> (ø)
es/utils/aepp-wallet-communication/helpers.js 100% <0%> (ø)
es/utils/hd-wallet.js 96% <0%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14937f1...d2b2524. Read the comment docs.

@nduchak nduchak added the enhancement New feature or request label Jan 30, 2020
@nduchak nduchak added this to the 7.0.0 milestone Jan 30, 2020
@nduchak nduchak merged commit f463237 into develop Jan 31, 2020
@nduchak nduchak deleted the refactor/oracle branch January 31, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants