Feat(ACI): Implement Contract Events #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nduchak
changed the title
|
Resolve #428 |
@todo: investigate and handle all types allowed in event body
nduchak
force-pushed
the
feat/contract-events
branch
from
dec2b39
to
ff25b10
Compare
|
This pull request introduces 1 alert when merging ff25b10 into 358e673 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #893 +/- ##
===========================================
+ Coverage 92.86% 92.98% +0.11%
===========================================
Files 57 57
Lines 2846 2880 +34
===========================================
+ Hits 2643 2678 +35
+ Misses 203 202 -1
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging ad47035 into 358e673 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 20ea4d0 into 358e673 - view on LGTM.com new alerts:
|
…de events without ACI
nduchak
force-pushed
the
feat/contract-events
branch
from
7f64182
to
e3fbbc5
Compare
nduchak
force-pushed
the
feat/contract-events
branch
from
b1ace11
to
ddda4d4
Compare
mradkov
approved these changes
Feb 11, 2020
Add test's for Events decoding without ACI Adjust `contract-events` guide Minor ACI validation improvement
nduchak
force-pushed
the
feat/contract-events
branch
from
7d52e5d
to
d06692b
Compare
nduchak
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.