Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AEX-2): Use hex string for signMessage response #911

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Feb 21, 2020

Extend verifyMessage with ability to accept buffer or hex

Extend `verifyMessage` with ability to accept `buffer` or `hex`
@nduchak nduchak added the enhancement New feature or request label Feb 21, 2020
@nduchak nduchak added this to the 7.1.0 milestone Feb 21, 2020
@nduchak nduchak requested a review from mradkov February 21, 2020 14:24
@nduchak nduchak self-assigned this Feb 21, 2020
Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #911 into develop will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #911     +/-   ##
==========================================
+ Coverage    92.74%   92.94%   +0.2%     
==========================================
  Files           57       57             
  Lines         2935     2936      +1     
==========================================
+ Hits          2722     2729      +7     
+ Misses         213      207      -6
Impacted Files Coverage Δ
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 98.93% <ø> (ø) ⬆️
es/account/memory.js 100% <100%> (ø) ⬆️
es/account/index.js 100% <100%> (ø) ⬆️
es/channel/handlers.js 79.27% <0%> (-0.46%) ⬇️
es/channel/internal.js 96.09% <0%> (+0.78%) ⬆️
es/utils/json-big.js 84.13% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6970efe...c20bb1d. Read the comment docs.

@nduchak nduchak merged commit f2d5e6c into develop Feb 21, 2020
@nduchak nduchak deleted the feat/improve-verify-message branch February 21, 2020 14:43
@mradkov mradkov mentioned this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants