RpcClient: Simplify message id processing #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #916 +/- ##
===========================================
+ Coverage 92.71% 92.73% +0.01%
===========================================
Files 57 57
Lines 2936 2944 +8
===========================================
+ Hits 2722 2730 +8
Misses 214 214
Continue to review full report at Codecov.
|
nduchak
approved these changes
Feb 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageIdinRpcClientis defined as a constant, and it is passed tosendMessageandreceivemethods as a primitive value, but as I know primitive variables are passed by values (not by reference) so it can't be mutated outside of function scope, alsomessageIdcan't be mutated because it is defined as a constant.So, I propose to drop not working and confusing code.