Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Keystore): Allow to store secret as hex or buffer #939

Merged
merged 1 commit into from
Mar 18, 2020
Merged

feat(Keystore): Allow to store secret as hex or buffer #939

merged 1 commit into from
Mar 18, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Mar 17, 2020 •
edited
Loading

KeyStore.dump accept secret as hex or buffer

@nduchak nduchak self-assigned this Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

Merging #939 into develop will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #939      +/-   ##
===========================================
- Coverage    93.01%   92.74%   -0.27%     
===========================================
  Files           58       58              
  Lines         2992     2992              
===========================================
- Hits          2783     2775       -8     
- Misses         209      217       +8
Impacted Files Coverage Δ
es/utils/keystore.js 100% <ø> (ø) ⬆️
es/utils/json-big.js 81.25% <0%> (-2.89%) ⬇️
es/channel/internal.js 95.31% <0%> (-0.79%) ⬇️
es/channel/handlers.js 79.27% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c012818...31a0b49. Read the comment docs.

@nduchak nduchak requested a review from mradkov March 17, 2020 15:33
@nduchak nduchak added this to the 7.2.0 milestone Mar 17, 2020
@nduchak nduchak added the enhancement New feature or request label Mar 17, 2020
mradkov
mradkov approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nduchak nduchak merged commit 72c123e into develop Mar 18, 2020
@nduchak nduchak deleted the feat/adjust-keystore-argument-resolver branch March 18, 2020 11:54
@nduchak nduchak mentioned this pull request Mar 24, 2020
Merged
@mradkov mradkov mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mradkov mradkov mradkov approved these changes

Assignees

@nduchak nduchak

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nduchak @mradkov