Fix bug preventing runtime registered components from being sorted in…

…to componentOrder
aframevr · Mar 11, 2024 · 4478a5e · 4478a5e
1 parent 8e95cd1
commit 4478a5e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/core/scene/a-scene.js b/src/core/scene/a-scene.js
@@ -146,7 +146,7 @@ class AScene extends AEntity {
     this.componentOrder = solveOrder(components, this.componentOrder);
     this.addEventListener('componentregistered', function () {
       // Recompute order
-      this.componentOrder = solveOrder(components, this.componentOrder);
+      self.componentOrder = solveOrder(components, self.componentOrder);
     });
 
     // WebXR Immersive navigation handler.

diff --git a/tests/core/scene/a-scene.test.js b/tests/core/scene/a-scene.test.js
@@ -97,6 +97,17 @@ suite('a-scene (without renderer) - WebXR', function () {
       assert.ok(sceneEl.hasAttribute('screenshot'));
       assert.ok(sceneEl.hasAttribute('xr-mode-ui'));
     });
+
+    test('recomputes component order upon component registration', function () {
+      var sceneEl = this.el;
+      var componentCount = sceneEl.componentOrder.length;
+
+      assert.ok(componentCount > 0);
+      assert.notIncludeMembers(sceneEl.componentOrder, ['test']);
+      registerComponent('test', {});
+      assert.equal(sceneEl.componentOrder.length, componentCount + 1);
+      assert.includeMembers(sceneEl.componentOrder, ['test']);
+    });
   });
 
   suite('vrdisplaydisconnect', function () {