Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Far clipping doesn't work properly in WebXR browsers #4387

Closed
DougReeder opened this issue Jan 5, 2020 · 4 comments
Closed

Far clipping doesn't work properly in WebXR browsers #4387

DougReeder opened this issue Jan 5, 2020 · 4 comments
Milestone

Comments

@DougReeder
Copy link
Contributor

Description:
Objects > 1000m away, but within camera far clipping plane, should be visible. Under WebVR, they are. Under WebXR, they are not.

The render state appears to be set with the baseLayer, but not depthNear nor depthFar

session.updateRenderState( { baseLayer: new XRWebGLLayer( session, gl,
  {
    antialias: gl.getContextAttributes().antialias,
    alpha: gl.getContextAttributes().alpha,
    depth: gl.getContextAttributes().depth,
    stencil: gl.getContextAttributes().stencil
  }
) } );

https://immersive-web.github.io/webxr/#xrrenderstate-interface

It's also possible that the maximum far clip plane is only 1000 on these platforms (which is legal)

@dmarcos
Copy link
Member

dmarcos commented Jan 6, 2020

WebXR default is 1000 and there's no way to change it at the moment. We should incorporate a way to override the default in WebXRManager

@DougReeder
Copy link
Contributor Author

Presuming a fix is made to Three.js, would it be preferable to cherry-pick the fix to super-three, or merge the latest version of Three.js?

@dmarcos
Copy link
Member

dmarcos commented Jan 9, 2020

It depends. Cherry-pick if we want to ship it in a minor version 1.0.X

Bumping THREE versions is disruptive and we can rebase for major versions 1.X.0

@dmarcos
Copy link
Member

dmarcos commented Jan 24, 2020

We can cherry-pick this for 1.0.4. Thanks for the effort on THREE

dmarcos added a commit that referenced this issue Feb 5, 2020
@dmarcos dmarcos closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants