-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oculus-touch-controls.js:347 Uncaught TypeError: Cannot read properties of undefined (reading 'trigger') #5220
Comments
Probably a button is pressed before the model is loaded, we'll need to verify that
There is also a similar issue in #5212 If anyone having a Quest 2 have one of those issues, those are really simple changes to make your first PR. |
Oh I didn't see it was also you who reported the other one. Can you try making a PR? |
PRs def welcome |
…, this fixes Quest 2 buttons highlighting errors when the model is not loaded yet (fix aframevr#5212 and aframevr#5220)
It should be fixed in #5223, if you can test @mikemainguy that would be awesome. |
… model is loaded (#5223) * Check if buttonObjects or buttonMeshes is defined before accessing it, this fixes Quest 2 buttons highlighting errors when the model is not loaded yet (fix #5212 and #5220) * check this.buttonMeshes before calling this.onButtonChangedV3 * Revert "check this.buttonMeshes before calling this.onButtonChangedV3" This reverts commit 7b2cda9.
I used "(fix #5212 and #5220)" in the commit comment but it didn't close the second issue, maybe because of the "and"? |
never tried that. I believe comma should work |
Description:
Navigate to above site:
oculus-touch-controls.js:347 Uncaught TypeError: Cannot read properties of undefined (reading 'trigger')
at NewComponent.onButtonChangedV3 (oculus-touch-controls.js:347:48)
at NewComponent.onButtonChanged (oculus-touch-controls.js:316:12)
at AEntity.bound (bind.js:12:17)
at AEntity.emit (a-node.js:287:10)
at NewComponent.handleButton (tracked-controls-webxr.js:134:13)
at NewComponent.updateButtons (tracked-controls-webxr.js:115:12)
at NewComponent.tick (tracked-controls-webxr.js:81:12)
at AScene.tick (a-scene.js:696:30)
at AScene.render (a-scene.js:742:32)
at bound (bind.js:12:17)
The text was updated successfully, but these errors were encountered: