Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material dithering #4433

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Material dithering #4433

merged 4 commits into from
Feb 4, 2020

Conversation

Firepal
Copy link
Contributor

@Firepal Firepal commented Feb 3, 2020

Description:
Made material dithering available from the component and enabled by default as it is much more preferable than without.

Here's two images of a lit cube seen from above, with contrast edited in-post to show the difference dithering makes.
image

@dmarcos
Copy link
Member

dmarcos commented Feb 4, 2020

Thanks. We need to document the new property: https://github.com/aframevr/aframe/blob/master/docs/components/material.md

@Firepal
Copy link
Contributor Author

Firepal commented Feb 4, 2020

@dmarcos donesies

@dmarcos
Copy link
Member

dmarcos commented Feb 4, 2020

Thanks!

@dmarcos dmarcos merged commit ab8d851 into aframevr:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants