New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding should match scene's color management settings #5157

Merged

dmarcos merged 1 commit into aframevr:master from diarmidmackenzie:fix-5014

Nov 20, 2022

Contributor

diarmidmackenzie commented Nov 19, 2022 •

edited

Loading

Description:

Fix for #5014

Changes proposed:

encoding setting for screenshot is read from renderer, rather than assuming sRGB or Linear
unit tests to check interaction between colorManagement setting on scene, and encoding used in screenshots.


          encoding should match scene's color management settings

af4f06e

Member

dmarcos commented Nov 20, 2022

Thank you so much! 🏆 🥳

dmarcos merged commit 11bdac3 into aframevr:master

This was referenced Nov 21, 2022

1.3.0 Hellow WebVR screenshot looks washed out #5014

Closed

Image result from screenshot very dark #4915

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet