Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide fullscreen button in desktop mode on iPad #5191

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

vincentfretin
Copy link
Contributor

Description:

As discussed in #4814 hide the fullscreen button on iPad in desktop mode when cardboardModeEnabled is false, it just rendered a black screen.

Changes proposed:

  • Using utils.device.isMobileDeviceRequestingDesktopSite() to detect desktop mode on iPad

@dmarcos
Copy link
Member

dmarcos commented Dec 26, 2022

Is there any error in console? Fullscreen API not working on iPads? I tried quickly on one and the browser is entering some form of fullscreen mode (notice the x button on the top / left corner). I would investigate a bit more why we're rendering black

@vincentfretin
Copy link
Contributor Author

I don't know if there is an error or not, I have no idea how to get console.log on iPad Safari. I tried using VorlonJS last time but couldn't make it work anymore. I don't have any macOS.

@dmarcos
Copy link
Member

dmarcos commented Dec 26, 2022

I couldn't see any errors in console. Safari behavior is really bizarre. The fullscreen seems to engage: denoted by the X button on the top-left corner. Nothing renders but one can tap the x to exit the mode. I couldn't find any info anywhere about why this behavior. If fullscreen is really not available on iPad I would expect an error. As usual Safari is frustrating. Gonna merge this but hopefully we find a better way to handle this.

@dmarcos dmarcos merged commit cd38d4b into aframevr:master Dec 26, 2022
@vincentfretin vincentfretin deleted the hide-vr-button-ipad branch December 27, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants