Use fillPoses
and fillJointRadii
instead of getJointPose
#5298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the logic in
hand-tracking-controls
to usefillPoses
andfillJointRadii
instead of callinggetJointPose
many times over. The downside ofgetJointPose
is that it allocates temporary objects, which quickly becomes inefficient.As described in the WebXR hand input explainer
Also removed the offset on the reference space. It didn't seem to serve any purpose and only required the rest of the code to apply a counter offset to get the actual position of the hand joints.
Changes proposed:
fillPoses
andfillJointRadii
onceupdateHandMeshModel
,updateHandDotsModel
anddetectPinch
use these poses and radii.