Use AFRAME.utils.split in getComponentPropertyPath fixing caching behaviour #5467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed that that
AFRAME.utils.entity.getComponentPropertyPath
didn't properly use its cache. It constructed a cache and populated it, but never checked if strings were already cached. Meaning it would always recompute (= split), place in cache and then immediately return that value from the cache.This PR simply replaces the broken caching mechanism with
AFRAME.utils.split
, since the split utility also uses a cache internally. Added benefit is that the cache is now also shared between the two.Changes proposed:
AFRAME.utils.split
which internally caches