New storage settings #738
Merged
New storage settings #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New storage proposal settings
- There is no need to invalidate the proposal. - The config phase is automaticall done if a product is selected.
- Probe will always start from scratch. - Clients are in charge of requesting a new proposal with the previous settings, if needed (e.g., if the system is deprecated).
- The client calculates the proposal again using the previous settings. - The backend never reuses the previous settings on probing.
Adapt storage UI
imobachgs
approved these changes
Sep 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agama reads the information about the products offered for installation from a config file like /etc/agama.yaml. That config file contains an storage section which indicates the storage options (e.g., lvm, encryption, etc) and the volumes (file systems) to create in the target system.
Till now, that section was basically the same as the storage section for the YaST config file. But the storage use cases for Agama are only a subset of all the possibities YaST offers. Some YaST settings simply do not make sense for Agama.
This feature redefines the storage settings for Agama, making the products configuration more straightforward and less error prone.
Notes
This PR merges the storage-settings feature branch into master. Everything has been already reviewed:
Follow-up: #721