Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 3.8 #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

hugovk
Copy link

@hugovk hugovk commented Oct 10, 2024

Changes

Drop support for EOL Python 3.8.

Remove redundant code and upgrade syntax for 3.9+.

https://discuss.python.org/t/python-3-8-is-now-officially-eol/66983

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • [n/a] You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.

Updating the changelog

If there are no entries after the last release, use **UNRELEASED** as the version.
If, say, your patch fixes issue #999, the entry should look like this:

* Fix big bad boo-boo in the encoder (#999 <https://github.com/agronholm/cbor2/issues/999>_; PR by @yourgithubaccount)

If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.

@@ -26,7 +26,7 @@ jobs:
uses: pypa/cibuildwheel@v2.21.3
env:
CBOR2_BUILD_C_EXTENSION: "1"
CIBW_SKIP: pp* cp36* cp37*
CIBW_SKIP: pp*
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cibuildwheel looks at requires-python in pyproject.toml so we don't need to explicitly list the old ones here.

https://cibuildwheel.pypa.io/en/stable/options/#requires-python

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps that has changed in a while because I added these specifically to block the creation of wheels for these versions after testing first. Or I may misremember and maybe I just added these based on a potential misunderstanding of their docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some vague recollection of that too.

This feature was added in pypa/cibuildwheel#536 which was released in https://github.com/pypa/cibuildwheel/releases/tag/2.5.0 in 2022, so not that long ago.

@coveralls
Copy link

Coverage Status

coverage: 93.542%. remained the same
when pulling 73a108a on hugovk:master
into 6427d37 on agronholm:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants