Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since 0.6.0 kctx doesn't work anymore #78

Closed
adebasi opened this issue Aug 24, 2018 · 2 comments
Closed

Since 0.6.0 kctx doesn't work anymore #78

adebasi opened this issue Aug 24, 2018 · 2 comments

Comments

@adebasi
Copy link

adebasi commented Aug 24, 2018

Setup:
I am using MacOS and installed kubectx this way:

brew install kubectx --with-short-names

I just upgraded to 0.6.0.

Problem:
Running kctx command shows fzf-view and [$FZF_DEFAULT_COMMAND failed]

Cause:
I found the line of code which causes trouble: https://github.com/ahmetb/kubectx/blob/master/kubectx#L94

choice="$(FZF_DEFAULT_COMMAND='kubectx' fzf --ansi || true)"

kubectx does not exist in my environment, because I installed kubectx with --with-short-names. I only have kctx
@ahmetb
Copy link
Owner

ahmetb commented Aug 24, 2018

Sending out a fix shortly. I also realized this is a problem.

ahmetb added a commit that referenced this issue Aug 24, 2018
@ahmetb
fix: --with-short-names not compatible with fzf
45fd315 
When kubectx is installed as kctx, FZF_DEFAULT_COMMAND=kubectx won't work.

Fixes #78.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb mentioned this issue Aug 24, 2018
Merged
ahmetb added a commit that referenced this issue Aug 24, 2018
@ahmetb
fix: --with-short-names not compatible with fzf (#79)
f01719a 
When kubectx is installed as kctx, FZF_DEFAULT_COMMAND=kubectx won't work.

Fixes #78.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
ahmetb added a commit that referenced this issue Aug 24, 2018
@ahmetb
Release v0.6.1
d931779 
- FIX: fix crash when kubectx/kubens is installed --with-short-names and fzf(1)
  is in PATH, but calling the binaries with the wrong name. (#78)
@ahmetb
Copy link
Owner

ahmetb commented Aug 24, 2018

You can now download 0.6.1 via brew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmetb @adebasi