fix collision by proxy number #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artalar
force-pushed
the
proxy-number-collision
branch
from
398fd90
to
397c549
Compare
|
Thanks. Fixed was released in 3.1.31. |
This was referenced Feb 10, 2022
Open
This was referenced Feb 10, 2022
Closed
This was referenced Feb 12, 2022
CVE-2021-23566 (Medium) detected in nanoid-3.1.12.tgz - autoclosed
billmcchesney1/react-bootstrap#87
Closed
This was referenced Feb 12, 2022
Closed
Closed
This was referenced Apr 7, 2022
This was referenced Apr 15, 2022
This was referenced Dec 18, 2022
quadratz
added a commit
to quadratz/nanoid-deno
that referenced
this pull request
Jun 13, 2024
This test should not be for non-secure in the first place. The test is only valid for the secure one to test the vulnerability (ai#328).
quadratz
added a commit
to quadratz/nanoid-deno
that referenced
this pull request
Jun 13, 2024
* feat: handle 'NaN' size Do not allow a 'NaN' value for the id size as it may lead to an infinite loop in the function. * test: remove proxy number test for non-secure This test should not be for non-secure in the first place. The test is only valid for the secure one to test the vulnerability (ai#328).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test live reproduce here https://stackblitz.com/edit/nanoid-collision?file=index.js (type
node index.jsin the console)