Fix meta data handling in ROOTReader and unify tests #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
unify-tests
branch
from
4d5bfd9
to
8d8c5bb
Compare
|
Rebased to fix the merge conflict. Can the two commits here be squashed into one when merging? Then the |
|
Since #97 changed the behavior of the EventStore (exception on non-existant collections), the tests needed some changes as well. |
tmadlener
force-pushed
the
unify-tests
branch
from
dbebb26
to
da42fcd
Compare
Make write / read tests reuse the same function Significantly reduces code dupliation by having the write and processEvent functions defined only once and re-used throughout all the read and write tests. Also increases test coverage in some places (e.g. MetaData have only been partially covered until now) and reduces future maintenance costs.
tmadlener
force-pushed
the
unify-tests
branch
from
da42fcd
to
1f7f4e9
Compare
hegner
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ROOTReaderhandle file switches properly for meta data reading.ENDRELEASENOTES
Fixes #132
In principle #132 is not yet completely fixed by this, because only the run, collection and event meta data are handled properly. Each file also has another metadata collection which currently is not yet updated during a file switch.
Unifying the testing code by making
readandread-multipleuse the sameprocessEventfunction (which lead to the discovery #132). Additionally makingwritea template function to easily switch out different writers. This significantly reduces code duplication, increases test coverage and also (hopefully) makes maintenance a bit easier in the future.