Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憣 Allow remote copying/symlinking between computers with same hostname #6196

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Nov 29, 2023

Fixes #6136

@khsrali
Copy link
Contributor

khsrali commented Jun 29, 2024

Thanks, @mbercx.
After looking at your issue #6136, I think one can add an extra check if both computers are using the same transport plugins.

Also, instead of changing the if condition, I would do it in the else block instead, because in case the server wouldn't allow it --for security reasons, etc--, it's probably better to catch the very similar errors (FileNotFoundError / OSError ) in a different place, for debugging, logging messages, etc.. as they have different nature.

Note also, the destination_path input in many methods in transport plugins: copy, get, put can be relative paths!,, so these methods need to be called with an absolute path if an operation between two computers is intended.

Just fished out another issues related to yours :) #1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃憣 Allow copying between different computers with same hostname
2 participants