Avoid calling update_cookies when there are no cookies (#9470)

aio-libs · Oct 11, 2024 · 5bded30 · 5bded30
1 parent 8a4707e
commit 5bded30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGES/9470.misc.rst b/CHANGES/9470.misc.rst
@@ -0,0 +1 @@
+Improved performance of the client request lifecycle when there are no cookies -- by :user:`bdraco`.
diff --git a/aiohttp/client.py b/aiohttp/client.py
@@ -335,7 +335,7 @@ def __init__(
             cookie_jar = CookieJar()
         self._cookie_jar = cookie_jar
 
-        if cookies is not None:
+        if cookies:
             self._cookie_jar.update_cookies(cookies)
 
         self._connector_owner = connector_owner
@@ -679,7 +679,8 @@ async def _request(
                             raise
                         raise ClientOSError(*exc.args) from exc
 
-                    self._cookie_jar.update_cookies(resp.cookies, resp.url)
+                    if cookies := resp.cookies:
+                        self._cookie_jar.update_cookies(cookies, resp.url)
 
                     # redirects
                     if resp.status in (301, 302, 303, 307, 308) and allow_redirects: