Disabling retry_persistent_connection in Tests (#9396)

CHANGES/9141.misc.rst

@@ -0,0 +1,2 @@
+Disabled automatic retries of failed requests in :class:`aiohttp.test_utils.TestClient`'s client session
+(which could potentially hide errors in tests) -- by :user:`ShubhAgarwal-dev`.

CONTRIBUTORS.txt

@@ -309,6 +309,7 @@ Sergey Skripnick
 Serhii Charykov
 Serhii Kostel
 Serhiy Storchaka
+Shubh Agarwal
 Simon Kennedy
 Sin-Woo Bang
 Stanislas Plum

aiohttp/client.py

@@ -254,6 +254,7 @@ class ClientSession:
         "_resolve_charset",
         "_default_proxy",
         "_default_proxy_auth",
+        "_retry_connection",
     )
 
     def __init__(
@@ -367,6 +368,7 @@ def __init__(
 
         self._default_proxy = proxy
         self._default_proxy_auth = proxy_auth
+        self._retry_connection: bool = True
 
     def __init_subclass__(cls: Type["ClientSession"]) -> None:
         raise TypeError(
@@ -539,7 +541,9 @@ async def _request(
         try:
             with timer:
                 # https://www.rfc-editor.org/rfc/rfc9112.html#name-retrying-requests
-                retry_persistent_connection = method in IDEMPOTENT_METHODS
+                retry_persistent_connection = (
+                    self._retry_connection and method in IDEMPOTENT_METHODS
+                )
                 while True:
                     url, auth_from_url = strip_auth_from_url(url)
                     if not url.raw_host:

aiohttp/test_utils.py

@@ -294,6 +294,7 @@ def __init__(  # type: ignore[misc]
         if cookie_jar is None:
             cookie_jar = aiohttp.CookieJar(unsafe=True)
         self._session = ClientSession(cookie_jar=cookie_jar, **kwargs)
+        self._session._retry_connection = False
         self._closed = False
         self._responses: List[ClientResponse] = []
         self._websockets: List[ClientWebSocketResponse] = []

tests/test_test_utils.py

@@ -11,6 +11,7 @@
 
 import aiohttp
 from aiohttp import web
+from aiohttp.pytest_plugin import AiohttpClient
 from aiohttp.test_utils import (
     AioHTTPTestCase,
     RawTestServer,
@@ -316,6 +317,27 @@ def test_noop(self) -> None:
     result.stdout.fnmatch_lines(["*TypeError*"])
 
 
+async def test_disable_retry_persistent_connection(
+    aiohttp_client: AiohttpClient,
+) -> None:
+    num_requests = 0
+
+    async def handler(request: web.Request) -> web.Response:
+        nonlocal num_requests
+
+        num_requests += 1
+        request.protocol.force_close()
+        return web.Response()
+
+    app = web.Application()
+    app.router.add_get("/", handler)
+    client = await aiohttp_client(app)
+    with pytest.raises(aiohttp.ServerDisconnectedError):
+        await client.get("/")
+
+    assert num_requests == 1
+
+
 async def test_server_context_manager(
     app: web.Application, loop: asyncio.AbstractEventLoop
 ) -> None: