Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payload.py now uses async/await syntax #2452

Merged
merged 1 commit into from
Oct 31, 2017
Merged

payload.py now uses async/await syntax #2452

merged 1 commit into from
Oct 31, 2017

Conversation

eteamin
Copy link
Contributor

@eteamin eteamin commented Oct 31, 2017

issue #2343
however IOBasePayload and BytesPayload classes still use the old style async syntax for their write coroutines. Because changing their write coroutine to new syntax raises TypeError: object tuple can't be used in 'await' expression that I was unable to fix.

@codecov-io
Copy link

Codecov Report

Merging #2452 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2452      +/-   ##
==========================================
- Coverage   97.15%   97.15%   -0.01%     
==========================================
  Files          39       39              
  Lines        8124     8123       -1     
  Branches     1419     1419              
==========================================
- Hits         7893     7892       -1     
  Misses         99       99              
  Partials      132      132
Impacted Files Coverage Δ
aiohttp/payload.py 98.85% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab1f23...24c9d9f. Read the comment docs.

@asvetlov asvetlov merged commit 4f7c91b into aio-libs:master Oct 31, 2017
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants