Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8672/c3219bf backport][3.11] Fix TCPConnector doing blocking I/O in the event loop to create the SSLContext #8674

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 10, 2024

Co-authored-by: Sam Bull git@sambull.org
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c3219bf)

…SLContext (#8672)

Co-authored-by: Sam Bull <git@sambull.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c3219bf)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 10, 2024
@bdraco bdraco changed the title Fix TCPConnector doing blocking I/O in the event loop to create the SSLContext (#8672) [PR #8672/c3219bf backport][3.11] Fix TCPConnector doing blocking I/O in the event loop to create the SSLContext Aug 10, 2024
@bdraco bdraco marked this pull request as ready for review August 10, 2024 15:03
@bdraco bdraco enabled auto-merge (squash) August 10, 2024 15:03
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (3f452a0) to head (5177268).

Additional details and impacted files
@@            Coverage Diff             @@
##             3.11    #8674      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +0.01%     
==========================================
  Files         108      108              
  Lines       33984    34015      +31     
  Branches     4047     4047              
==========================================
+ Hits        33185    33219      +34     
+ Misses        598      595       -3     
  Partials      201      201              
Flag Coverage Δ
CI-GHA 97.56% <100.00%> (+0.01%) ⬆️
OS-Linux 97.24% <100.00%> (+0.07%) ⬆️
OS-Windows 94.82% <100.00%> (+0.09%) ⬆️
OS-macOS 96.96% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.01% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.95% <100.00%> (-0.29%) ⬇️
Py-3.12.4 97.25% <100.00%> (+0.21%) ⬆️
Py-3.8.10 94.43% <100.00%> (+0.01%) ⬆️
Py-3.8.18 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.94% <100.00%> (+0.32%) ⬆️
Py-3.9.19 96.90% <100.00%> (?)
VM-macos 96.96% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.24% <100.00%> (+0.07%) ⬆️
VM-windows 94.82% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit adf4dea into 3.11 Aug 10, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/c3219bf88c2a9381c50cd18a0fc1ad701e39bb9a/pr-8672 branch August 10, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant