[3.11] Fix AsyncResolver query fallback swallowing the error message #9455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same change as #9451 but for the query fallback code for older versions of aiodns
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
added
the
backport-3.10
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9455 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 108 108
Lines 35112 35130 +18
Branches 4192 4198 +6
==========================================
+ Hits 34349 34372 +23
+ Misses 569 565 -4
+ Partials 194 193 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9456 🤖 @patchback |
bdraco
added a commit
that referenced
this pull request
Oct 10, 2024
…wallowing the error message (#9456) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same change as #9451 but for the query fallback code for older versions of aiodns