Add additional coverage for joining urls

[bdraco]

What do these changes do?

#1039 introduced a regression in decoding query string params with %2B (aka +). Add coverage to ensure we do not miss this again in the future.

Are there changes in behavior for the user?

no

Related issue number

#1039

[bdraco]

I think #1039 needs to be reworked to use URL( self._val._replace(.....), encoded=True, ) instead

[codecov]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (94b6b51) to head (51faa7c).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
tests/test_url.py	95.45%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   92.89%   92.91%   +0.01%     
==========================================
  Files          26       26              
  Lines        4295     4317      +22     
  Branches      356      356              
==========================================
+ Hits         3990     4011      +21     
- Misses        279      280       +1     
  Partials       26       26              

Flag	Coverage Δ
CI-GHA	92.88% <95.45%> (+0.01%)	⬆️
MyPy	25.53% <0.00%> (-0.14%)	⬇️
OS-Linux	99.26% <100.00%> (+<0.01%)	⬆️
OS-Windows	99.58% <100.00%> (+<0.01%)	⬆️
OS-macOS	99.02% <100.00%> (+<0.01%)	⬆️
Py-3.10.11	98.90% <100.00%> (+<0.01%)	⬆️
Py-3.10.14	99.11% <100.00%> (+<0.01%)	⬆️
Py-3.11.9	99.11% <100.00%> (+<0.01%)	⬆️
Py-3.12.5	99.11% <100.00%> (+<0.01%)	⬆️
Py-3.13.0-rc.1	99.11% <100.00%> (+<0.01%)	⬆️
Py-3.8.10	98.87% <100.00%> (+<0.01%)	⬆️
Py-3.8.18	99.08% <100.00%> (+<0.01%)	⬆️
Py-3.9.13	98.87% <100.00%> (+<0.01%)	⬆️
Py-3.9.19	99.08% <100.00%> (+<0.01%)	⬆️
Py-pypy7.3.11	99.39% <100.00%> (+<0.01%)	⬆️
Py-pypy7.3.16	99.42% <100.00%> (+<0.01%)	⬆️
VM-macos-latest	99.02% <100.00%> (+<0.01%)	⬆️
VM-ubuntu-latest	99.26% <100.00%> (+<0.01%)	⬆️
VM-windows-latest	99.58% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

@codecov codecov/patch — 0.00% of diff hit (target 62.37%) isn't passing so this one won't merge as its marked as required

[webknjaz]

@bdraco this should probably be force-merged for now. It's likely because of the Codecov v4 bug we saw earlier. I'm yet to file a report upstream.

[bdraco]

@webknjaz looks like I don’t have the proper GitHub access to override checks for this repo.