Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid quoting empty strings when building URLs #1126

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 7, 2024

What do these changes do?

We guard against quoting empty strings in new but not in build

Quoting is the most expensive operation besides parsing IPs

Are there changes in behavior for the user?

no

We guard against quoting empty strings in __new__ but not in build

Quoting is the most expensive operation besides parsing IPs
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (164a045) to head (34d5781).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files          30       30           
  Lines        4635     4636    +1     
  Branches      409      409           
=======================================
+ Hits         4409     4410    +1     
  Misses        200      200           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.08% <100.00%> (+<0.01%) ⬆️
MyPy 41.07% <100.00%> (+0.01%) ⬆️
OS-Linux 99.38% <100.00%> (ø)
OS-Windows 99.47% <100.00%> (ø)
OS-macOS 99.08% <100.00%> (ø)
Py-3.10.11 98.97% <100.00%> (ø)
Py-3.10.14 99.21% <100.00%> (ø)
Py-3.11.9 99.21% <100.00%> (ø)
Py-3.12.5 99.21% <100.00%> (ø)
Py-3.13.0-rc.1 99.21% <100.00%> (ø)
Py-3.8.10 98.92% <100.00%> (ø)
Py-3.8.18 99.16% <100.00%> (ø)
Py-3.9.13 98.92% <100.00%> (ø)
Py-3.9.19 99.16% <100.00%> (ø)
Py-pypy7.3.11 99.21% <100.00%> (ø)
Py-pypy7.3.16 99.21% <100.00%> (ø)
Py-pypy7.3.17 99.24% <100.00%> (ø)
VM-macos-latest 99.08% <100.00%> (ø)
VM-ubuntu-latest 99.38% <100.00%> (ø)
VM-windows-latest 99.47% <100.00%> (ø)
pytest 99.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 7, 2024 22:13
@bdraco bdraco merged commit 7e94253 into master Sep 7, 2024
47 of 49 checks passed
@bdraco bdraco deleted the no_quote_empty branch September 7, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant