Migrate to using propcache for property caching #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
31 tasks
bdraco
commented
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1169 +/- ##
==========================================
- Coverage 95.62% 95.57% -0.05%
==========================================
Files 30 25 -5
Lines 4981 4864 -117
Branches 464 443 -21
==========================================
- Hits 4763 4649 -114
+ Misses 192 189 -3
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
psf-chronographer
bot
added
the
bot:chronographer:provided
bdraco
changed the title
bdraco
commented
Oct 5, 2024
bdraco
force-pushed
the
switch_to_propcache
branch
from
10effdf
to
0707c4f
Compare
webknjaz
reviewed
Oct 5, 2024
webknjaz
reviewed
Oct 5, 2024
webknjaz
reviewed
Oct 5, 2024
webknjaz
reviewed
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
bdraco
commented
Oct 6, 2024
|
https://github.com/aio-libs/propcache/actions/runs/11197845167/job/31128986852#step:10:31 publish of propcache 1.0.0 failed |
bdraco
commented
Oct 7, 2024
bdraco
commented
Oct 7, 2024
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
bdraco
force-pushed
the
switch_to_propcache
branch
from
798e5d7
to
0cdbdb9
Compare
webknjaz
approved these changes
Oct 7, 2024
|
Thanks |
|
I need to retest this on production with all the latest one more time before merging. Then I can do a release. Maybe tomorrow depending on how much time my day job takes up and how jet lagged I am |
|
testing in production passed |
This was referenced Oct 8, 2024
mamccorm
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 8, 2024
Adds a new python package: py3-propcache. The primary reason for adding this, was due to a new buildtime dependency introduced by the following (existing) package: #30252. Theres more info about the buildtime [dependency introduction here](aio-libs/yarl#1169). Signed-off-by: Mark McCormick <mark.mccormick@chainguard.dev>
mamccorm
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 8, 2024
Package update. This also required introducing a new buildtime dependency: py3-propcache. See [upstream commit](aio-libs/yarl#1169) for info on when this was introduced. ----- <p align="center"> <img src="https://raw.githubusercontent.com/wolfi-dev/.github/b535a42419ce0edb3c144c0edcff55a62b8ec1f8/profile/wolfi-logo-light-mode.svg" /> </p> --------- Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com> Signed-off-by: Mark McCormick <mark.mccormick@chainguard.dev> Co-authored-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com> Co-authored-by: Mark McCormick <mark.mccormick@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
#1070 (comment)
Replaces
cached_propertywith a shared implementation calledpropcachethat will be maintained in a single place foryarlandaiohttpThe
propcachepackage is derived from the property caching code inyarland has been broken out to avoid maintaining it for multiple projects.Are there changes in behavior for the user?
The
propcachedep is now requiredRelated issue number
#1070 (comment)