Fix IPv6 zone handling, lowercase in domain name and compressed ip ad… #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketpair
commented
Dec 14, 2017
| except ValueError: | ||
| pass | ||
| netloc = netloc.encode('idna').decode('ascii') |
There was a problem hiding this comment.
In [15]: timeit 'lasdhglajkdshflkajsdfh.asdf.asdf.asdf.asdf.asdf.rtyty'.encode('ascii')
1000000 loops, best of 3: 283 ns per loop
In [16]: timeit 'lasdhglajkdshflkajsdfh.asdf.asdf.asdf.asdf.asdf.rtyty'.encode('idna').decode('ascii')
100000 loops, best of 3: 2.77 µs per loop
There was a problem hiding this comment.
Sorry, don't follow the question.
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 99.63% 99.63% +<.01%
==========================================
Files 2 2
Lines 542 544 +2
Branches 135 137 +2
==========================================
+ Hits 540 542 +2
Partials 2 2
Continue to review full report at Codecov.
|
asvetlov
reviewed
Dec 17, 2017
| else: | ||
| (ip, *zone) = netloc.split('%', 1) |
|
Merged by 7d8f58b |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dresses.