Added an option to toggle debug mode #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jun 24, 2017
index.js
Outdated
| @@ -24,10 +24,12 @@ module.exports = function buildAirbnbPreset(context, options) { | |||
| var transpileTargets = (options && options.targets) || | |||
| buildTargets(options || {}); | |||
|
|
|||
| var debug = options.debug !== undefined ? options.debug : true; | |||
There was a problem hiding this comment.
i think it'd actually be better to default it to false - ie, var debug = typeof options.debug === 'boolean' ? ‼options.debug : false;
There was a problem hiding this comment.
I've switched to false by default.
But I don't really get why should we use !! before options.debug. After all if type of options.debug is boolean then the value is (bool) true or (bool) false
Closed
ljharb
approved these changes
Jun 28, 2017
1pete
reviewed
Jul 17, 2017
| @@ -24,10 +24,12 @@ module.exports = function buildAirbnbPreset(context, options) { | |||
| var transpileTargets = (options && options.targets) || | |||
| buildTargets(options || {}); | |||
|
|
|||
| var debug = (options && typeof options.debug === 'boolean') ? !!options.debug : false; | |||
There was a problem hiding this comment.
If type of options.debug is boolean, it is redundant to double negate it, isn't it?
There was a problem hiding this comment.
Sure, that's a fair point. Doesn't hurt tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to toggle debug mode in babel-preset-env by using debug variable