feat(shape): add more segmentation for SplitLinePath #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
commented
Jul 1, 2021
kristw
commented
Jul 1, 2021
kristw
commented
Jul 1, 2021
kristw
commented
Jul 1, 2021
packages/visx-demo/src/sandboxes/visx-shape-splitlinepath/generateSnakePath.ts
Show resolved
Hide resolved
kristw
commented
Jul 1, 2021
packages/visx-demo/src/sandboxes/visx-shape-splitlinepath/generateSinPoints.ts
Show resolved
Hide resolved
williaster
reviewed
Jul 1, 2021
packages/visx-demo/src/sandboxes/visx-shape-splitlinepath/generateSnakePath.ts
Show resolved
Hide resolved
packages/visx-demo/src/sandboxes/visx-shape-splitlinepath/generateSinSegments.ts
Show resolved
Hide resolved
packages/visx-demo/src/sandboxes/visx-shape-splitlinepath/generateSinPoints.ts
Show resolved
Hide resolved
…/generateSnakePath.ts Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
|
Thanks for all the comments. Addressed all. |
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
SplitLinePathcan split line by multiple algorithmsx: Split based on x-position, assuming x values increase only (segment[i].x > segment[i-1].x) or decrease only (segment[i].x < segment[i-1].x).y: Split based on y-position, assuming y values increase only (segment[i].y > segment[i-1].y) or decrease only (segment[i].y < segment[i-1].y).length: Assuming the path length between consecutive points are equal. (This was the original algorithm that led to SplitLinePath: The segments are not split correctly #920.)Default is set to
x.📝 Documentation
SplitLinePathexample🐛 Bug Fix