MAINT: Standardize styles with black #1289
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One reason to leave this be for now is that it makes rebasing all the existing PRs a huge pain. However, there are few enough of them that it might make sense to just bite the bullet and go ahead with it. |
|
Given the number of contributors to ASV, this seems like churn for very little gain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enforce linting rules (now with
ruffas of #1260) but without an auto-formatter the burden falls on the user to make sure the code conforms. I'd rather just defer toblackfor ensuring the code will pass the linter, it works well withruffand doesn't seem to be too much uglier or even that different (subjectively).