Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: make typer optional and move to faststream[cli] distribution #1430

Closed
Lancetnik opened this issue May 8, 2024 · 3 comments · Fixed by #1769
Closed

Feature: make typer optional and move to faststream[cli] distribution #1430

Lancetnik opened this issue May 8, 2024 · 3 comments · Fixed by #1769
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Lancetnik
Copy link
Member

Lancetnik commented May 8, 2024 •
edited
Loading

Also we should update documentation accordingly
@Lancetnik Lancetnik added enhancement New feature or request good first issue Good for newcomers labels May 8, 2024
@Lancetnik
Copy link
Member Author

I think, we should remove CLI typer dependency from default destribution and move it to faststream[cli] optionals (with watchfiles probably)

@RubenRibGarcia
Copy link
Contributor

RubenRibGarcia commented Sep 4, 2024 •
edited
Loading

Hey @Lancetnik, I would like to contribute to this repository and would like to pick this issue. I already start working on this probably by the end of this week I might open a PR.

Don't know if need more anything to be assigned for this task

@Lancetnik
Copy link
Member Author

@RubenRibGarcia thank you for your interest! I will wait for PR from you 😄

RubenRibGarcia added a commit to RubenRibGarcia/faststream that referenced this issue Sep 6, 2024
@RubenRibGarcia
build(airtai#1430): separate cli faststream to its own distribution
468f49e
@RubenRibGarcia RubenRibGarcia mentioned this issue Sep 6, 2024
Merged
11 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 9, 2024
@RubenRibGarcia @kumaranvpl @Lancetnik
build(#1430): separate cli faststream to its own distribution (#1769)
521eaf2 
* build(#1430): separate cli faststream to its own distribution

* ci: add cli target to smoke job tests

* docs: mentioned fastream cli distribution on documnetation and README

* Update faststream.md

* chore: restrict watchfiles version

* chore: bump version

---------

Co-authored-by: Kumaran Rajendhiran <kumaran@airt.ai>
Co-authored-by: Pastukhov Nikita <nikita@pastukhov-dev.ru>
Co-authored-by: Nikita Pastukhov <diementros@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
FastStream
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(#1430): separate cli faststream to its own distribution RubenRibGarcia/faststream
2 participants
@RubenRibGarcia @Lancetnik