Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add broker.request method #1649

Merged
merged 37 commits into from
Aug 24, 2024
Merged

feat: add broker.request method #1649

merged 37 commits into from
Aug 24, 2024

Conversation

Lancetnik
Copy link
Member

@Lancetnik Lancetnik commented Aug 6, 2024

Description

Close #557, close #1603, close #1640

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added enhancement New feature or request Core Issues related to core FastStream functionality and affects to all brokers labels Aug 6, 2024
@Lancetnik Lancetnik marked this pull request as draft August 6, 2024 17:00
@Lancetnik Lancetnik marked this pull request as ready for review August 13, 2024 15:27
@Lancetnik Lancetnik requested review from kumaranvpl and sternakt and removed request for kumaranvpl and sternakt August 13, 2024 15:55
@Lancetnik Lancetnik marked this pull request as draft August 13, 2024 15:55
@Lancetnik Lancetnik marked this pull request as ready for review August 14, 2024 17:20
@Lancetnik Lancetnik marked this pull request as ready for review August 23, 2024 20:47
@Lancetnik
Copy link
Member Author

Ready to merge as 0.5.19

@Lancetnik Lancetnik requested review from davorrunje and kumaranvpl and removed request for kumaranvpl, sternakt and davorrunje August 24, 2024 06:16
@Lancetnik Lancetnik marked this pull request as draft August 24, 2024 06:22
@Lancetnik Lancetnik marked this pull request as ready for review August 24, 2024 16:04
@Lancetnik Lancetnik added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit 8ec5a42 Aug 24, 2024
29 checks passed
@Lancetnik Lancetnik deleted the feat/requests branch August 24, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request
Projects
Archived in project
3 participants