Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect ignored exceptions #1735

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Lancetnik
Copy link
Member

Description

ExceptionMiddleware should not catch AckMessage, NackMessage, SkipMessage, etc exceptions

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the bug Something isn't working label Aug 28, 2024
@davorrunje
Copy link
Collaborator

@Lancetnik tests failed

@Lancetnik
Copy link
Member Author

@Lancetnik tests failed

They didn't fail. Not commit doesn't trigger tests CI for some reason, we should add a new trigger. I reported the problem already

@kumaranvpl kumaranvpl added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit af63e30 Aug 29, 2024
19 of 32 checks passed
@kumaranvpl kumaranvpl deleted the fix/exception-middleware-respect-ignored-exceptions branch August 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants