Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update FastAPI to 0.112.2 #1736

Merged
merged 12 commits into from
Aug 30, 2024
Merged

fix: update FastAPI to 0.112.2 #1736

merged 12 commits into from
Aug 30, 2024

Conversation

Lancetnik
Copy link
Member

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added the bug Something isn't working label Aug 28, 2024
@Lancetnik Lancetnik self-assigned this Aug 28, 2024
@Lancetnik Lancetnik marked this pull request as draft August 28, 2024 16:01
@Lancetnik Lancetnik marked this pull request as ready for review August 29, 2024 20:48
@Lancetnik
Copy link
Member Author

I just can't test docs generation due it didn't trigger at PR commit

@kumaranvpl
Copy link
Contributor

I just can't test docs generation due it didn't trigger at PR commit

@Lancetnik Are you saying that Generate API References documentation is not triggered automatically for PRs?
I could see list of runs here - https://github.com/airtai/faststream/actions/workflows/docs_update-references.yaml?query=branch%3Afix%2Fupdate-fastapi

@kumaranvpl kumaranvpl added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 79c7b78 Aug 30, 2024
32 checks passed
@kumaranvpl kumaranvpl deleted the fix/update-fastapi branch August 30, 2024 04:24
@Lancetnik
Copy link
Member Author

@Lancetnik Are you saying that Generate API References documentation is not triggered automatically for PRs?
I could see list of runs here - https://github.com/airtai/faststream/actions/workflows/docs_update-references.yaml?query=branch%3Afix%2Fupdate-fastapi

I just can't understand the trigger logic. Seems like it runs only at first commit in PR. Probably, GH had some lags yesterday. Anyway, we should change this action user to make it triggering test CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants