Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zone_file.erb #31

Merged
merged 1 commit into from
Jan 10, 2014
Merged

Update zone_file.erb #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/zone_file.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ $TTL <%= @zone_ttl %>
<%= @zone_minimum %> ) ; Negative Cache TTL
;
<% @nameservers.each do |nameserver| -%>
@ IN NS <%= @nameserver %>.
@ IN NS <%= nameserver -%>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ syntax is preferred, variables will not always be available as ruby methods:
http://docs.puppetlabs.com/guides/templating.html#referencing-variables

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ syntax will not work at puppet 2.7 in this case, which is used in Ubuntu 12.04 LTS.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I apologize, this variable is inside the erb loop, not something being called out of puppet scope.
http://docs.puppetlabs.com/guides/templating.html#iteration

Carry on! :)

<% end -%>
;