Skip to content

Commit

Permalink
Fix service => service namespace bug
Browse files Browse the repository at this point in the history
  • Loading branch information
ben-toogood committed May 21, 2020
1 parent 344ce06 commit 287992c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
1 change: 0 additions & 1 deletion auth/rules/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ func Verify(namespace string, rules []*auth.Rule, acc *auth.Account, res *auth.R
// filter the rules to the ones which match the criteria above
filteredRules := make([]*auth.Rule, 0)
for _, rule := range rules {
fmt.Printf("All rules: %v\n", rule.ID)
if !include(validTypes, rule.Resource.Type) {
continue
}
Expand Down
2 changes: 1 addition & 1 deletion util/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func Generate(id string, name string, a auth.Auth) error {
if err != nil {
return err
}
logger.Infof("Auth [%v] Authenticated as %v in the %v scope", a, name, scope)
logger.Infof("Auth [%v] Authenticated as %v in the %v namespace", a, name, a.Options().Namespace)

accID = acc.ID
accSecret = acc.Secret
Expand Down
8 changes: 6 additions & 2 deletions util/wrapper/wrapper.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package wrapper
import (
"context"
"strings"
"time"

"github.com/micro/go-micro/v2/auth"
"github.com/micro/go-micro/v2/client"
Expand Down Expand Up @@ -156,9 +155,14 @@ func (a *authWrapper) Call(ctx context.Context, req client.Request, rsp interfac
return a.Client.Call(ctx, req, rsp, opts...)
}

// set the namespace header if it has not been set (e.g. on a service to service request)
if _, ok := metadata.Get(ctx, "Micro-Namespace"); !ok {
ctx = metadata.Set(ctx, "Micro-Namespace", aa.Options().Namespace)
}

// check to see if we have a valid access token
aaOpts := aa.Options()
if aaOpts.Token != nil && aaOpts.Token.Expiry.Unix() > time.Now().Unix() {
if aaOpts.Token != nil && !aaOpts.Token.Expired() {
ctx = metadata.Set(ctx, "Authorization", auth.BearerScheme+aaOpts.Token.AccessToken)
return a.Client.Call(ctx, req, rsp, opts...)
}
Expand Down

0 comments on commit 287992c

Please sign in to comment.