Skip to content

Commit

Permalink
Switch to Marionette by default in the Python client
Browse files Browse the repository at this point in the history
Marionette tests can be run using ./go //py:marionette_test:run
  • Loading branch information
davehunt committed May 19, 2016
1 parent 5b85c32 commit a91690b
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 13 deletions.
2 changes: 1 addition & 1 deletion py/build.desc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ py_test(

py_test(
name = "marionette_test",
deps = [ ":test_ff" ],
deps = [ ":test_marionette" ],
browsers = [ "marionette" ])

py_test(
Expand Down
2 changes: 1 addition & 1 deletion py/selenium/webdriver/common/desired_capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class DesiredCapabilities(object):
"version": "",
"platform": "ANY",
"javascriptEnabled": True,
"marionette": False,
"marionette": True,
}

INTERNETEXPLORER = {
Expand Down
14 changes: 8 additions & 6 deletions py/test/selenium/webdriver/firefox/ff_launcher_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,24 +23,26 @@
class FirefoxLauncherTests (unittest.TestCase):

def testLaunchAndCloseBrowser(self):
self.webdriver = webdriver.Firefox()
capabilities = {'marionette': False}
self.webdriver = webdriver.Firefox(capabilities=capabilities)
self.webdriver.quit()

def testDoubleClose(self):
self.webdriver = webdriver.Firefox()
capabilities = {'marionette': False}
self.webdriver = webdriver.Firefox(capabilities=capabilities)
self.webdriver.close()
self.webdriver.close()
self.webdriver.quit()

def test_we_can_launch_multiple_firefox_instances(self):
self.webdriver1 = webdriver.Firefox()
self.webdriver2 = webdriver.Firefox()
self.webdriver3 = webdriver.Firefox()
capabilities = {'marionette': False}
self.webdriver1 = webdriver.Firefox(capabilities=capabilities)
self.webdriver2 = webdriver.Firefox(capabilities=capabilities)
self.webdriver3 = webdriver.Firefox(capabilities=capabilities)
self.webdriver1.quit()
self.webdriver2.quit()
self.webdriver3.quit()

if __name__ == "__main__":
logging.basicConfig(level=logging.INFO)
unittest.main()

7 changes: 5 additions & 2 deletions py/test/selenium/webdriver/firefox/ff_profile_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
class TestFirefoxProfile:

def setup_method(self, method):
self.driver = webdriver.Firefox()
self.capabilities = {'marionette': False}
self.driver = webdriver.Firefox(capabilities=self.capabilities)
self.webserver = SimpleWebServer()
self.webserver.start()

Expand All @@ -49,7 +50,9 @@ def test_that_we_can_accept_a_profile(self):
profile1.update_preferences()

profile2 = webdriver.FirefoxProfile(profile1.path)
driver = webdriver.Firefox(firefox_profile=profile2)
driver = webdriver.Firefox(
capabilities=self.capabilities,
firefox_profile=profile2)
title = driver.title
driver.quit()
assert "Hello WebDriver" == title
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@


from selenium import webdriver
from selenium.test.selenium.webdriver.common import select_class_tests
from selenium.test.selenium.webdriver.common import select_class_tests
from selenium.test.selenium.webdriver.common.webserver import SimpleWebServer

def setup_module(module):
webserver = SimpleWebServer()
webserver.start()
FirefoxSelectElementHandlingTests.webserver = webserver
FirefoxSelectElementHandlingTests.driver = webdriver.Firefox()
capabilities = {'marionette': False}
FirefoxSelectElementHandlingTests.driver = webdriver.Firefox(
capabilities=capabilities)


class FirefoxSelectElementHandlingTests(select_class_tests.WebDriverSelectSupportTests):
Expand All @@ -34,4 +36,3 @@ class FirefoxSelectElementHandlingTests(select_class_tests.WebDriverSelectSuppor
def teardown_module(module):
FirefoxSelectElementHandlingTests.driver.quit()
FirefoxSelectElementHandlingTests.webserver.stop()

2 changes: 2 additions & 0 deletions rake-tasks/browsers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
:dir => "firefox", # Directory to put tests in/read tests from
:file_string => "ff", # Browser-string to use in test filenames
:class => "Firefox", # As per py/selenium/webdriver/__init__.py
:constructor_args => "capabilities={'marionette': False}",
:resources => [
{ "//javascript/firefox-driver:webdriver" => "selenium/webdriver/firefox/" },
{ "//cpp:noblur" => "selenium/webdriver/firefox/x86/x_ignore_nofocus.so" },
Expand All @@ -27,6 +28,7 @@
:dir => "firefox", # Directory to put tests in/read tests from
:file_string => "marionette", # Browser-string to use in test filenames
:class => "Firefox", # As per py/selenium/webdriver/__init__.py
:constructor_args => "capabilities={'marionette': True}"
},
:java => {
:class => "org.openqa.selenium.firefox.SynthesizedFirefoxDriver",
Expand Down

0 comments on commit a91690b

Please sign in to comment.