Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=doc #1290 Merge common/json-support.md #1348

Merged
merged 3 commits into from
Aug 15, 2017
Merged

Conversation

jonas
Copy link
Member

@jonas jonas commented Aug 14, 2017

References #1290

Akka HTTP's @ref[marshalling](marshalling.md) and @ref[unmarshalling](unmarshalling.md) infrastructure makes it rather easy to seamlessly convert application-domain objects from and to JSON.
Integration with @scala[[spray-json]]@java[[Jackson]] is provided out of the box through the @scala[`akka-http-spray-json`]@java[`akka-http-jackson`] module.
Integration with other JSON libraries are supported by the community.
See [the list of current community extensions for Akka HTTP](https://index.scala-lang.org/search?topics=akka-http&topics=json).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to directly link to scaladex since the community page now simply links there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1, let's link to the community page since scala index sometimes changes the query url and then we'll just have one place where we need to fix the link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, restored.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Aug 14, 2017
@akka-ci
Copy link

akka-ci commented Aug 14, 2017

Test PASSed.

@jonas jonas changed the title Merge JSON support pages =doc #1290 Merge common/json-support.md Aug 14, 2017
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Aug 14, 2017
@akka-ci
Copy link

akka-ci commented Aug 14, 2017

Test PASSed.

<version>$project.version$</version>
</dependency>
```
@@@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! 👍

Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonas jonas merged commit aee2f0f into akka:master Aug 15, 2017
@jonas jonas deleted the json-support branch August 15, 2017 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants