Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=doc #1818 formatting issue in websocket docs #1820

Merged
merged 2 commits into from
Jan 29, 2018
Merged

=doc #1818 formatting issue in websocket docs #1820

merged 2 commits into from
Jan 29, 2018

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Jan 29, 2018

No description provided.

@ktoso
Copy link
Member Author

ktoso commented Jan 29, 2018

Resolves #1818

@ktoso ktoso requested a review from raboof January 29, 2018 10:01
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Jan 29, 2018
raboof
raboof reviewed Jan 29, 2018
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another one a bit further down: "@scala[`Flow[Message, Message, Any]]]". Should be good after that!

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Jan 29, 2018
@akka-ci
Copy link

akka-ci commented Jan 29, 2018

Test PASSed.

ktoso
ktoso commented Jan 29, 2018
View reviewed changes
docs/src/main/paradox/server-side/websocket-support.md
Second, the application can optionally choose one of the proposed application-level sub-protocols by inspecting the
values of @scala[`UpgradeToWebSocket.requestedProtocols`]@java[`UpgradeToWebSocket.getRequestedProtocols`] and pass the chosen protocol value to @scala[`handleMessages`]@java[`handleMessagesWith`].

### Handling Messages

A message handler is expected to be implemented as a @scala[`Flow[Message, Message, Any]]]@java[@unidoc[Flow[Message, Message, ?]]]. For typical request-response
A message handler is expected to be implemented as a @scala[@unidoc[Flow[Message, Message, Any]]]@java[@unidoc[Flow[Message, Message, ?]]]. For typical request-response
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the additional catch @raboof

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jan 29, 2018
@akka-ci
Copy link

akka-ci commented Jan 29, 2018

Test PASSed.

@ktoso ktoso merged commit 3fb1f6a into master Jan 29, 2018
@ktoso ktoso deleted the ktoso-patch-1 branch January 29, 2018 11:44
jrudolph pushed a commit to jrudolph/akka-http that referenced this pull request Jan 29, 2018
@ktoso @jrudolph
[backport from master] =doc akka#1818 formatting issue in websocket d…
c75cd4d 
…ocs (akka#1820)

* =doc akka#1818 formatting issue in websocket docs

* Update websocket-support.md
jrudolph pushed a commit to jrudolph/akka-http that referenced this pull request Jan 29, 2018
@ktoso @jrudolph
[backport from master] =doc akka#1818 formatting issue in websocket d…
33c7cee 
…ocs (akka#1820)

* =doc akka#1818 formatting issue in websocket docs

* Update websocket-support.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof left review comments

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @akka-ci @raboof