Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=pro create initial version of release train issue template #2288

Merged
merged 5 commits into from
Jan 2, 2019
Merged

=pro create initial version of release train issue template #2288

merged 5 commits into from
Jan 2, 2019

Conversation

jrudolph
Copy link
Member

No description provided.

@jrudolph jrudolph requested a review from raboof November 22, 2018 13:03
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Nov 22, 2018
@jrudolph jrudolph force-pushed the jr/release-train-template branch 2 times, most recently from 89c2b10 to ef50f6c Compare November 22, 2018 13:07
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Nov 22, 2018
@akka-ci
Copy link

akka-ci commented Nov 22, 2018

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Nov 22, 2018
@akka-ci akka-ci added the tested PR that was successfully built and tested by Jenkins label Nov 22, 2018
@akka-ci akka-ci removed the validating PR that is currently being validated by Jenkins label Nov 22, 2018
@akka-ci
Copy link

akka-ci commented Nov 22, 2018

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Nov 22, 2018
@akka-ci
Copy link

akka-ci commented Nov 22, 2018

Test PASSed.

raboof
raboof reviewed Nov 22, 2018
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty excellent! Added a couple of minor comments

notes/RELEASING.md Outdated Show resolved Hide resolved
notes/release-train-issue-template.md Outdated Show resolved Hide resolved
notes/release-train-issue-template.md Outdated Show resolved Hide resolved
notes/release-train-issue-template.md Outdated Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Nov 22, 2018
@akka-ci
Copy link

akka-ci commented Nov 22, 2018

Test PASSed.

jlprat
jlprat reviewed Nov 22, 2018
View reviewed changes
Copy link
Member

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

notes/release-train-issue-template.md Outdated Show resolved Hide resolved
notes/release-train-issue-template.md Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed tested PR that was successfully built and tested by Jenkins labels Dec 19, 2018
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Dec 19, 2018
@akka-ci
Copy link

akka-ci commented Dec 19, 2018

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Dec 19, 2018
@akka-ci
Copy link

akka-ci commented Dec 19, 2018

Test PASSed.

@jrudolph jrudolph added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Dec 20, 2018
raboof
raboof approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already great, we can iterate further on master

@raboof raboof added this to the 10.1.7 milestone Jan 2, 2019
@raboof raboof merged commit 01b7576 into akka:master Jan 2, 2019
franktominc pushed a commit to franktominc/akka-http that referenced this pull request Jun 12, 2019
@jrudolph @franktominc
=pro create initial version of release train issue template (akka#2288)
9239e48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlprat jlprat jlprat left review comments

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jrudolph @akka-ci @raboof @jlprat