Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache refresh without remove #2385 #2522

Merged
merged 9 commits into from
Jun 6, 2019
Merged

Cache refresh without remove #2385 #2522

merged 9 commits into from
Jun 6, 2019

Conversation

ashishkujoy
Copy link
Contributor

Purpose

Provided a put method in cache API and implemented the same in Lfu cache, this method takes a key and future value, if the key is not already cached it save key into the cache and in case key is already cached, it replaces the old cache value on once future value successfully completes

References

#2385

References #xxxx

Changes

Added put method in Cache

Background Context

@akka-ci
Copy link

akka-ci commented May 7, 2019

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof
Copy link
Member

raboof commented May 7, 2019

OK TO TEST

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels May 7, 2019
@akka-ci
Copy link

akka-ci commented May 7, 2019

Test PASSed.

raboof
raboof reviewed May 7, 2019
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some race conditions here but since it's a cache perhaps that's no problem.

The logic looks OK to me, but can perhaps be simplified, and might possibly be faster as well, by avoiding store.synchronous()?

akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Outdated Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels May 7, 2019
@akka-ci
Copy link

akka-ci commented May 7, 2019

Test PASSed.

raboof
raboof reviewed May 7, 2019
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, one more thought

akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Outdated Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels May 7, 2019
@akka-ci
Copy link

akka-ci commented May 7, 2019

Test FAILed.

@ashishkujoy
Copy link
Contributor Author

Why does Jenkins PR Validation fails saying

sed: can't read ./akka-http2-support/target/test-reports/h2spec-junit.xml: No such file or directory

I haven't changed anything related to that

@raboof
Copy link
Member

raboof commented May 8, 2019

PLS BUILD

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels May 8, 2019
@akka-ci
Copy link

akka-ci commented May 8, 2019

Test PASSed.

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels May 26, 2019
@akka-ci
Copy link

akka-ci commented May 26, 2019

Test PASSed.

raboof
raboof approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

akka-http-caching/src/main/scala/akka/http/caching/scaladsl/Cache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/scaladsl/Cache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/test/scala/akka/http/caching/ExpiringLfuCacheSpec.scala Outdated Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 2, 2019
@akka-ci
Copy link

akka-ci commented Jun 2, 2019

Test PASSed.

jrudolph
jrudolph reviewed Jun 5, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ashishkujoy. The feature seems useful, a few detail questions and suggestions below.

akka-http-caching/src/main/scala/akka/http/caching/scaladsl/Cache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/scaladsl/Cache.scala Outdated Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Show resolved Hide resolved
akka-http-caching/src/main/scala/akka/http/caching/LfuCache.scala Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 5, 2019
@akka-ci
Copy link

akka-ci commented Jun 5, 2019

Test PASSed.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 5, 2019
@akka-ci
Copy link

akka-ci commented Jun 5, 2019

Test PASSed.

jrudolph
jrudolph approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @ashishkujoy!

@jrudolph jrudolph merged commit c577e8b into akka:master Jun 6, 2019
@jrudolph jrudolph mentioned this pull request Jun 6, 2019
Closed
@raboof
Copy link
Member

raboof commented Jun 6, 2019

Great!

@ashishkujoy ashishkujoy deleted the caching branch June 11, 2019 14:28
franktominc pushed a commit to franktominc/akka-http that referenced this pull request Jun 12, 2019
@ashishkujoy @franktominc
Add Cache.put method to refresh cached value without removing it first …
87d78de 
…akka#2385 (akka#2522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashishkujoy @akka-ci @raboof @jrudolph