Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate HttpApp #3162

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Deprecate HttpApp #3162

merged 4 commits into from
Jun 25, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented May 15, 2020

References #3155

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels May 15, 2020
@akka-ci
Copy link

akka-ci commented May 15, 2020

Test FAILed.

!!! Couldn't read commit file !!!

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jun 10, 2020
@akka-ci
Copy link

akka-ci commented Jun 10, 2020

Test PASSed.

@mfirry mfirry mentioned this pull request Jun 17, 2020
Closed
@ennru ennru requested a review from jrudolph June 24, 2020 11:42
jrudolph
jrudolph approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/src/main/paradox/routing-dsl/index.md Outdated
@@ -57,8 +56,6 @@ Scala
Java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you keep the lines above intentionally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could I not see this? Removed.

docs/src/test/scala/docs/http/scaladsl/HttpAppExampleSpec.scala Outdated
import docs.CompileOnlySpec
import org.scalatest.matchers.should.Matchers
import org.scalatest.wordspec.AnyWordSpec

@silent("deprecated")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason to keep the docs examples around?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped them now.

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR that is currently being validated by Jenkins labels Jun 24, 2020
@akka-ci
Copy link

akka-ci commented Jun 24, 2020

Test PASSed.

@jrudolph jrudolph requested a review from raboof June 25, 2020 09:05
@raboof raboof merged commit 20be53d into akka:master Jun 25, 2020
@ennru ennru mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrudolph jrudolph jrudolph approved these changes

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ennru @akka-ci @jrudolph @raboof