Add directives for extracting attributes #3355
Conversation
akka-ci
added
validating
|
Test PASSed. |
|
|
||
| ## Description | ||
|
|
||
| Extracts the value of the request attribute with the given key. |
There was a problem hiding this comment.
Link to the Attribute docs for more context. Possibly explain how the attribute would get there before hitting the routing DSL.
akka-ci
added
validating
|
Test PASSed. |
There was a problem hiding this comment.
LGTM functionality wise
attribute is concise, I wonder, though, if it's clear what is meant if you read it in a route? Also since there are both request and response attributes.
On the other hand, we aren't quite consistent about that even now. Some extractions are called extractXYZ (extractMethod, extractUri, etc.) while other are not (cookie, headerByType, etc.).
So overall, I think I'm good with this suggestion. I guess it's fine to not mark it as @ApiMayChange for now? It shouldn't be a too common piece, so maybe let's not fret about it.
Later we should also add a directive to add a response attribute.
Refs #3315