Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add handlePF directive #3367

Merged
merged 6 commits into from
Jul 16, 2020
Merged

http: add handlePF directive #3367

merged 6 commits into from
Jul 16, 2020

Conversation

jrudolph
Copy link
Member

@jrudolph jrudolph commented Jul 14, 2020 •
edited by raboof
Loading

Refs #3239, #3263

Before I continue, I'd like some feedback on API and naming.

@jrudolph jrudolph requested a review from raboof July 14, 2020 10:31
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Jul 14, 2020
@akka-ci
Copy link

akka-ci commented Jul 14, 2020

Test FAILed.

!!! Couldn't read commit file !!!

raboof
raboof reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good direction to me. Nice to also have the Sync variants. Likely they'll be less common so indeed good to give those the more verbose name.

akka-http/src/main/scala/akka/http/scaladsl/server/directives/RouteDirectives.scala Outdated Show resolved Hide resolved
akka-http/src/main/scala/akka/http/scaladsl/server/directives/RouteDirectives.scala Outdated Show resolved Hide resolved
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jul 14, 2020
@akka-ci
Copy link

akka-ci commented Jul 14, 2020

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-tests / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 3 minutes, 25 seconds.
[info] Total number of tests run: 1264
[info] Suites: completed 64, aborted 0
[info] Tests: succeeded 1261, failed 3, canceled 0, ignored 0, pending 40
[info] *** 3 TESTS FAILED ***
[error] Failed: Total 1423, Failed 3, Errors 0, Passed 1420, Pending 40
[error] Failed tests:
[error] 	akka.http.javadsl.DirectivesConsistencySpec

@jrudolph
rename to handle/handleSync
33614c8 
and merge documentation pages
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Jul 14, 2020
@jrudolph jrudolph marked this pull request as ready for review July 14, 2020 12:26
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels Jul 14, 2020
@akka-ci
Copy link

akka-ci commented Jul 14, 2020

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'akka-http-tests / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 4 minutes, 41 seconds.
[info] Total number of tests run: 1262
[info] Suites: completed 64, aborted 0
[info] Tests: succeeded 1261, failed 1, canceled 0, ignored 0, pending 40
[info] *** 1 TEST FAILED ***
[error] Failed: Total 1421, Failed 1, Errors 0, Passed 1420, Pending 40
[error] Failed tests:
[error] 	akka.http.javadsl.DirectivesConsistencySpec

Test result for 'docs / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 4 minutes, 40 seconds.
[info] Total number of tests run: 287
[info] Suites: completed 59, aborted 0
[info] Tests: succeeded 285, failed 2, canceled 0, ignored 0, pending 0
[info] *** 2 TESTS FAILED ***
[error] Failed: Total 509, Failed 2, Errors 0, Passed 494, Skipped 13
[error] Failed tests:
[error] 	docs.http.scaladsl.server.directives.RouteDirectivesExamplesSpec

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jul 14, 2020
@akka-ci
Copy link

akka-ci commented Jul 14, 2020

Test FAILed.

Pull request validation report

Failed Test Suites

Test result for 'docs / Pr-validation / ./ executeTests'

[info] ScalaTest
[info] Run completed in 4 minutes, 36 seconds.
[info] Total number of tests run: 287
[info] Suites: completed 59, aborted 0
[info] Tests: succeeded 285, failed 2, canceled 0, ignored 0, pending 0
[info] *** 2 TESTS FAILED ***
[error] Failed: Total 509, Failed 2, Errors 0, Passed 494, Skipped 13
[error] Failed tests:
[error] 	docs.http.scaladsl.server.directives.RouteDirectivesExamplesSpec

@raboof raboof mentioned this pull request Jul 15, 2020
Open
@akka-ci akka-ci added the validating PR that is currently being validated by Jenkins label Jul 15, 2020
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels Jul 15, 2020
@akka-ci
Copy link

akka-ci commented Jul 15, 2020

Test PASSed.

@jrudolph jrudolph requested a review from raboof July 16, 2020 11:47
@jrudolph
Copy link
Member Author

Nothing to add here from my side.

raboof
raboof approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Might be interesting to think about if we could come up with something for the javadsl, but it's not so obvious what a PartialFunction should look like there.

@jrudolph
Copy link
Member Author

Might be interesting to think about if we could come up with something for the javadsl, but it's not so obvious what a PartialFunction should look like there.

Yes, good point, I think akka-grpc also generates the scala signatures for partial on the Java side?

@jrudolph jrudolph changed the title add handlePF directive http: add handlePF directive Jul 16, 2020
@jrudolph jrudolph merged commit 12118aa into akka:master Jul 16, 2020
@jrudolph jrudolph deleted the handlePF branch July 16, 2020 14:01
@jrudolph jrudolph added this to the 10.2.0 milestone Jul 16, 2020
@raboof
Copy link
Member

raboof commented Jul 16, 2020

Yes, good point, I think akka-grpc also generates the scala signatures for partial on the Java side?

Not currently, but if we add a directive to convert a scala PartialFunction to a javadsl Route I think changing it to return a scaladsl PartialFunction might make sense!

(it currently returns a non-partial java function with a 'magic constant' representing 'no return value')

@jrudolph jrudolph mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrudolph @akka-ci @raboof